Code Comments
Programming Forum and web based access to our favorite programming groups.> Laurent Laville wrote: > down today included CVS. > Arnaud Limbourg wrote: > First I would like to point I will only express my opinion and not QA > team as as a whole. > > The problem is twofold I believe. On one hand you have people using > HTML_Progress, are these people affected by the changes ? will their > code run without any change ? My answer to this question is YES, except that warning will raise to keep them aware no to use the deprecated method, such as : $progress = new HTML_Progress(); ... $ui = & $progress->getUI(); // since the merge of 3 classes before i got $ui = instance of HTML_Progress_UI now i'll get $ui = instance of HTML_Progress and also for same reason $dm = & $progress->getDM(); > > On the other hand you have people extending HTML_progress. Are these > people affected by the changes ? Probably because to include HTML_Progress_UI inside HTML_Progress i 've extends HTML_common class HTML_Progress extends HTML_Common > Did you modify the public API that they > will need to modify their code ? I know PHP4 does not make any > difference between public and private but if the methods are documented > that's fine. No change on public API > > If the answer to any of these question is yes than I would consider it a > BC break. In any case the matter needs to be furthered considered. > > Arnaud. Thanks for your point of view Arnaud :) Laurent
Post Follow-up to this message
Show a Printable Version
Email This Page to Someone!
Receive updates to this thread
Powered by vBulletin
Copyright 2000-2006 Jelsoft Enterprises Limited.