|
| On Feb 10, 2008 4:59 PM, Philippe Jausions
<Philippe.Jausions@11abacus.com> wrote:
> Helgi =DEormar =DEorbj=F6rnsson wrote:
com>[color=darkred]
d[color=darkred]
e[color=darkred]
a tgz[color=darkred]
a[color=darkred]
he[color=darkred]
nner.[color=darkred]
>
> till wrote:
te:[color=darkred]
p[color=darkred]
>
> A relatively easy to implement solution would be to add a check box in
> the transition from "Draft" to "Proposed" that would say "I ran
> PHP_CodeSniffer on my proposal and it passes PEAR CS validation" (or
> split that in 2 phrases/checkboxes: 1. I ran PHP_CodeSniffer, 2. PEAR CS
> Ok.)
>
> As Till noted, people don't read "long" blurp, so a checkbox might be
> more effective. Bouncing back the proposal to Draft status for blatant
> non-compliance could nudge people into cleaning their code first.
+1
I think it just scares people off for the first time when they see the
manual entry, when technically all they need to do is run
PHP_CodeSniffer themselves. Not too much to comprehend and it's
convenient as hell. :-)
I'd also +1 for a commit-hook. ;-))
Till
|
|