PHP PEAR Questions and Answers - Re: [PEAR-QA] taking over SQL

Author

Re: [PEAR-QA] taking over SQL_Parser

Christian Weiske

2007-06-29, 4:00 am

Sebastian,

I looked over them - they look ok (left 1 comment).
[color=darkred]
Yes, that's a problem.

[color=darkred]
> without putting pressure on your, ti would be nice if you would come
> to any conclusion about getting developer status for SQL_Parser for me
Seeing your profile and rank on ohloh.net (you should take over the phpmyad=
min cybot user into your account) and the patches, I gave you dev karma and=
made you lead of Sql_Parser. I already asked the right people to grant you=
cvs access.

> - much documentation
Documentation is done in peardoc/ cvs module. We use docbook which can be h=
ard to get into first, but I'm happy to help you.

> - bringing code to PEAR standards
> - putting dialect data files into data?
I don't know anything about dialect files :)
If they are php, treat them as normal sources.

> - renaming Lexer to SQL_Lexer?
Using Lexer as class name is a clear violation of PEAR CS, it should be SQL=
_Parser_Lexer.

> ^^ needs this a second package? how should this be handled?
I don't think we need a second package, except there are many people intere=
sted in having a separate lexer for sql - which I think isn't the case.

> - does SQL_Compiler needs a seperate Package?
No, since it directly interacts with the structures used by SQL_Parser and =
is tightly tied with it.

> - what about ctype.php? is this the correct way to handle possible
> missing functions?
If you need to use functions that are not available everywhere, you normall=
y use PHP_Compat package. If this doesn't provide the functions, either do =
it yourself (such as the package did), or contribute to it.

> - what about tests, can i upgrade them to use PHPUnit 3?
Yes, this would be good.

> - does anybody knows what was the intention for
> Expressions/incldue.php?
CVS Log says: Adding a place to hold expressions that I will factor out of =
Parser.php
Factoring seems not to have begun, though.

> - package2.xml
You can completely drop package.xml v1 support. This said, if you use the r=
oadmap feature of the pear package website, you can generate package.xml fi=
les based on fixed bugs automatically.

Some closing words:
If you think that SQL_Parser needs a refactoring and don't want to keep old=
legacy code / API, the best thing is to start a new package that supersede=
s the old one and make it PHP5 only (since this is what the original intent=
ion for phpMyAdmin was if I understand correctly).
Of course, bugs that can be fixed should be fixed.

Welcome onboard.

--=20
Mit freundlichen Gr=FC=DFen/Regards,
Christian Weiske

Sebastian Mendel

2007-06-29, 4:00 am

Christian Weiske schrieb:
> (you should take over the phpmyadmin cybot user into your account)

what? where? into which account?

> Documentation is done in peardoc/ cvs module. We use docbook which can be hard to get into first, but I'm happy to help you.

ok, but phpDocumentor doc is missing everywhere - shouldn't this be there also?

> I don't know anything about dialect files :)
> If they are php, treat them as normal sources.

yes, they are PHP, but containing only arrays
shouldn't there be only Class definitions in this strcuture?

> No, since it directly interacts with the structures used by SQL_Parser and is tightly tied with it.

but SQL_Parser_Compiler?

> If you need to use functions that are not available everywhere, you normally use PHP_Compat package. If this doesn't provide the functions, either do it yourself (such as the package did), or contribute to it.

ok, so it is fine to have such a file ctype.php there?

> Some closing words:
> If you think that SQL_Parser needs a refactoring and don't want to keep old legacy code / API, the best thing is to start a new package that supersedes the old one and make it PHP5 only (since this is what the original intention for phpMyAdmin was if I
understand correctly).
> Of course, bugs that can be fixed should be fixed.

so i should not 'convert' this package to E_STRICT compatible?
even this package was created before 2007-01 but it has never left 'devel'
status

--
Sebastian Mendel

www.sebastianmendel.de

Sebastian Mendel

2007-06-29, 7:00 pm

Helgi Þormar Þorbjörnsson schrieb:
> Christian covered most things just fine :)
>
> On 6/29/07, Christian Weiske <cweiske@cweiske.de> wrote:> - what about
> ctype.php? is this the correct way to handle possible
>
>
> Require PHP 4.3.0 and boom ctype is enabled by default :)

default !== always

"make your application portable"

--
Sebastian

Sebastian Mendel

2007-06-30, 7:00 pm

Helgi Þormar Þorbjörnsson schrieb:
> On 6/29/07, Sebastian Mendel <lists@sebastianmendel.de> wrote:
>
>
> just read the manual, http://www.php.net/ctype
>
> To quote it:
>
> "*Note: * Builtin support for ctype is available with PHP 4.3.0."

we used ctype in phpMyAdmin and got bug reports about missing functions

some distros seem to use --disable-ctype and provide php_ctype.rpm or
something similar ...

--
Sebastian

Sponsored Links