| Carsten Wiedmann 2007-11-28, 7:03 pm |
| Gregory Beaver schrieb:
> Christian Weiske wrote:
>
> test is fixed to use an array instead of spaces. That test, btw, is
> probably the oldest test in the bunch - it predates my efforts to
> unit-test PEAR 1.4.0
This fix is not complete. "Concat in new file" is not the only part, where a
string is/was used. "Concat append to file" and "Concat to string" are also
using a string. Of course, the last one makes no sense without a string.
Thus I think it's better at the moment, to make sure that no path with space
is used in the test.
There is two other problema with "Concat to files with space in names"
(which is at the moment a comment).
a) you must use also an array in this test and not a string
b) System::mktemp() have also a problem with spaces (and maybe other parts
in "System.php" too?) (in my patch I use a similar trick as you)
This patch fixes this for me on XP and FreeBSD (the mktemp problem on
Windows too):
http://phpfi.com/279493
Regards,
Carsten
|