PHP PEAR Questions and Answers - Re: [PEAR-DEV] Re: [PEAR-QA] Re: [PEAR-DEV] Re: [PEAR-QA] Re: [PEAR-DEV] Re: [PEAR] [

You are viewing an archived Text-only version of the thread. To view this thread in it's original format and/or if you want to reply to this thread please [click here]

Author

Re: [PEAR-DEV] Re: [PEAR-QA] Re: [PEAR-DEV] Re: [PEAR-QA] Re: [PEAR-DEV] Re: [PEAR] [

Pierre

2006-06-19, 7:05 pm

On 6/19/06, Joe Stump <joe@joestump.net> wrote:
> I completely disagree with this. You're basically advocating code
> duplication. What should happen is one of the following:

You are (again) putting words in my mouth. I never said that
duplicating code is good. But in the case of php_compat, it is. That's
all.

> 1.) Optional dependency (noted in the docs)

Read the full thread, this solution was rejected.

> 2.) Up your PHP requirements

Again

> 3.) Let people running old versions of PHP install PHP_Compat on
> their own

Please check the lists archive.

> Copying and pasting code from one package to another should be
> discouraged IMO.

It is, in 99.99%. But nothing is black and white, there is a gray
area, sometimes small. This case is in the gray area and I think it is
a perfectly and sane choice to duplicate this portion of code.

Cheers,
--Pierre

Sponsored Links