Home > Archive > PHP PEAR Questions and Answers > April 2006 > [PEAR-QA ] BC break or not?
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
[PEAR-QA ] BC break or not?
|
|
| Philippe Jausions 2006-04-26, 6:59 pm |
| Hi,
I'm working on Crypt_Blowish and one of the problem with the existing
version is that it does things like this at different locations:
PEAR::raiseError('Plain text must be a string', 0, PEAR_ERROR_DIE);
which is not really user friendly for such a package.
Does changing it to:
return PEAR::raiseError('Plain text must be a string', 0);
constitue a BC break?
In essence, I guess it does, but how does one fix this kind of
situations without a BC break?
Thanks,
-Philippe
| |
| Pierre 2006-04-26, 6:59 pm |
| On 4/26/06, Philippe Jausions <Philippe.Jausions@11abacus.com> wrote:
> Hi,
>
> I'm working on Crypt_Blowish and one of the problem with the existing
> version is that it does things like this at different locations:
>
> PEAR::raiseError('Plain text must be a string', 0, PEAR_ERROR_DIE);
>
> which is not really user friendly for such a package.
>
> Does changing it to:
>
> return PEAR::raiseError('Plain text must be a string', 0);
>
> constitue a BC break?
>
> In essence, I guess it does, but how does one fix this kind of
> situations without a BC break?
No, it is a fixe (DIE is not allowed in pear packages).
--Pierre
| |
| Justin Patrin 2006-04-26, 6:59 pm |
| On 4/26/06, Philippe Jausions <Philippe.Jausions@11abacus.com> wrote:
> Hi,
>
> I'm working on Crypt_Blowish and one of the problem with the existing
> version is that it does things like this at different locations:
>
> PEAR::raiseError('Plain text must be a string', 0, PEAR_ERROR_DIE);
>
> which is not really user friendly for such a package.
>
> Does changing it to:
>
> return PEAR::raiseError('Plain text must be a string', 0);
>
> constitue a BC break?
>
> In essence, I guess it does, but how does one fix this kind of
> situations without a BC break?
>
I'd call that a misfeature, not a BC break. However, if you want to
keep BC you can introduce an option to not die.
--
Justin Patrin
| |
| Arnaud Limbourg 2006-04-26, 6:59 pm |
| It should not die so I would not qualify it as a BC break. Go ahead :)
Arnaud.
On Wed, 2006-26-04 at 13:46 -0400, Philippe Jausions wrote:
> Hi,
>
> I'm working on Crypt_Blowish and one of the problem with the existing
> version is that it does things like this at different locations:
>
> PEAR::raiseError('Plain text must be a string', 0, PEAR_ERROR_DIE);
>
> which is not really user friendly for such a package.
>
> Does changing it to:
>
> return PEAR::raiseError('Plain text must be a string', 0);
>
> constitue a BC break?
>
> In essence, I guess it does, but how does one fix this kind of
> situations without a BC break?
>
> Thanks,
>
> -Philippe
>
--
|
|
|
|
|