Home > Archive > PHP PEAR Questions and Answers > November 2005 > Re: [PEAR-QA] File_SearchReplace
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
Re: [PEAR-QA] File_SearchReplace
|
|
| Arnaud Limbourg 2005-11-03, 6:57 pm |
| anatoly techtonik wrote:
> Hello pear-qa,
>
> I'd like to deprecate File_SearchReplace package and introduce
> File_SearchandReplace. The difference is in minor, but vital BC
> break due to introducing doReplace() method and making doSearch()
> one r/o. All necessary diffs are already on CVS long ago.
> http://cvs.php.net/cvs.php/pear/File_SearchReplace
>
> t
Either you want to propose a new package that would deprecate
File_searchReplace or you maintain the current code.
The package is labeled stable so no BC break is allowed.
Arnaud.
| |
| Arnaud Limbourg 2005-11-12, 3:56 am |
| anatoly techtonik wrote:
>MT> Why not File_SearchReplace2, the usual way of breaking bc.
>
>Ok. Though I prefer to continue File_SearchReplace, because of CVS
>history and end of curent File_SearchReplace life-cycle (it will not
>be updated anymore), but it is ok to create File_SearchReplace2 module.
>
>Can anybody do it for me? Or I need to start a formal proposal?
>
>
>
Hllo,
You just need to create a new package on pearweb and mention the
discussion we had here.
It is unfortunate but the stable status prevents BC.
Arnaud.
| |
| bertrand Gugger 2005-11-12, 7:55 am |
| Bonjour,
Arnaud Limbourg wrote:
> anatoly techtonik wrote:
>
> Hllo,
>
> You just need to create a new package on pearweb and mention the
> discussion we had here.
>
> It is unfortunate but the stable status prevents BC.
>
> Arnaud.
>
As usual, it's me everything unclear here,
Anatoly, could you do a short resume of what's going on ?
What breaks BC ?
Where is the problem ?
Anyway, commits are watched out.
Sorry, I don't get it ...
a+
--
toggg
| |
| Arnaud Limbourg 2005-11-17, 6:57 pm |
| > For now the problems
> 1. I don't have access to pearweb to release a File_SearchReplace
> package even with CVS karma and
Someone from QA can take care of this if the CVS is ready and the only
thing needed is to roll a release.
> 2. I need to introduce new functionality, which will be BC break
> to File_SearchReplace
You will have to make it optionnal or implement it in such a way as to
not break BC.
The only BC break way will be to create File_SearchReplace2.
From the mail you posted [1] it looks like you could do
doSearch($replace = true); If you want to have replace explicit add a
property that sets the default behaviour.
The current default is to replace, it cannot be changed.
[1] http://marc.theaimsgroup.com/?l=pea...57022622511&w=2
Arnaud.
| |
| Arnaud Limbourg 2005-11-21, 6:58 pm |
| anatoly techtonik wrote:
> I can care for myself. Just give me correct privileges to pearweb.
> I've already got Richard's permission, what else do you need?
It is done, politeness does not hurt though.
> AL> The only BC break way will be to create File_SearchReplace2.
>
> Ok. I'll do it this way, but I still need access to release backport
> fixes into File_SearchReplace.
As long as there is no bc break.
>
>
> AL> doSearch($replace = true); If you want to have replace explicit add a
> AL> property that sets the default behaviour.
>
> Better keep it simple.
I fail to see how making a second package and backporting stuff is
simpler; feel free to enlighten me.
Arnaud.
|
|
|
|
|