Home > Archive > PHP PEAR Questions and Answers > October 2005 > Re: [PEAR-QA] [Fwd: marking bug status as "patch"]
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
Re: [PEAR-QA] [Fwd: marking bug status as "patch"]
|
|
| Arnaud Limbourg 2005-10-18, 7:56 am |
| Hi,
I think think this is a could idea.
Martin had started to work on a patch management system a while ago,
where does it stand ?
Helgi, would the following patch do the trick ?
========================================
===========================
RCS file: /repository/pearweb/public_html/bugs/include/functions.inc,v
retrieving revision 1.89
diff -u -r1.89 functions.inc
--- include/functions.inc 12 Oct 2005 18:05:38 -0000 1.89
+++ include/functions.inc 18 Oct 2005 10:13:32 -0000
@@ -49,6 +49,7 @@
$types = array(
'Bug' => 'Bug',
'Feature/Change Request' => 'Req',
+ 'Patch' => 'Patch'
);
Arnaud.
Lukas Smith wrote:
> maybe you guys want to push this idea on ..
>
> -------- Original Message --------
> Subject: marking bug status as "patch"
> Date: Thu, 13 Oct 2005 12:46:51 +0200
> From: lsmith@php.net (Lukas Smith)
> To: pear-webmaster@lists.php.net
> Newsgroups: php.pear.webmaster
>
> Hi,
>
> looking at the spreadsheet writer bugs I noticed a few bug reports have
> patches. i think it would be a good idea to be able to mark these bugs
> with the status "patch" .. this would make it easier for bug closing
> hunters to find these later on, so that they can quickly pick those low
> hanging fruits ..
>
> regards,
> Lukas
>
| |
| Martin Jansen 2005-10-18, 6:58 pm |
| On Tue Oct 18, 2005 at 12:1556PM +0200, Arnaud Limbourg wrote:
> Martin had started to work on a patch management system a while ago,
> where does it stand ?
I'm not working on this anymore. (In fact the thing never really took
off.)
- Martin
| |
| Alan Knowles 2005-10-18, 9:56 pm |
| One thing that may help here as well is to view the comment in a
textbox:
eg. for bugs.php
for the loop at the end:
output_note($row['id'], $row['added'], $row['email'], $row['comment'],
(isset($_GET['view_source']) && ($_GET['view_source'] == $row['id'])));
function output_note($com_id, $ts, $email, $comment, $view_source = 0)
....
if ($view_source) {
echo '<textarea cols="40"
rows="10">'.htmlspecialchars($comment)."</textarea>"
} else {
echo "<pre class=\"note\">";
$note = addlinks(preg_replace("/(\r?\n){3,}/","\n
\n",wordwrap($comment,72,"\n",1)));
echo preg_replace('/(bug\ *#([0-9]+))/i', "<a href=\"$self?id=\\2\">\
\1</a>", $note);
echo "</pre>\n";
}
Regards
Alan
On Tue, 2005-10-18 at 12:15 +0200, Arnaud Limbourg wrote:
> Hi,
>
> I think think this is a could idea.
>
> Martin had started to work on a patch management system a while ago,
> where does it stand ?
>
> Helgi, would the following patch do the trick ?
>
> ========================================
===========================
> RCS file: /repository/pearweb/public_html/bugs/include/functions.inc,v
> retrieving revision 1.89
> diff -u -r1.89 functions.inc
> --- include/functions.inc 12 Oct 2005 18:05:38 -0000 1.89
> +++ include/functions.inc 18 Oct 2005 10:13:32 -0000
> @@ -49,6 +49,7 @@
> $types = array(
> 'Bug' => 'Bug',
> 'Feature/Change Request' => 'Req',
> + 'Patch' => 'Patch'
> );
>
>
>
>
> Arnaud.
>
>
> Lukas Smith wrote:
>
| |
| Arnaud Limbourg 2005-10-19, 7:56 am |
| Alan's solution should help.
Helgi, can you test that and commit it if it works ?
Arnaud.
Alan Knowles wrote:
> One thing that may help here as well is to view the comment in a
> textbox:
>
> eg. for bugs.php
>
> for the loop at the end:
> output_note($row['id'], $row['added'], $row['email'], $row['comment'],
> (isset($_GET['view_source']) && ($_GET['view_source'] == $row['id'])));
>
> function output_note($com_id, $ts, $email, $comment, $view_source = 0)
> ...
> if ($view_source) {
> echo '<textarea cols="40"
> rows="10">'.htmlspecialchars($comment)."</textarea>"
>
> } else {
> echo "<pre class=\"note\">";
> $note = addlinks(preg_replace("/(\r?\n){3,}/","\n
> \n",wordwrap($comment,72,"\n",1)));
> echo preg_replace('/(bug\ *#([0-9]+))/i', "<a href=\"$self?id=\\2\">\
> \1</a>", $note);
> echo "</pre>\n";
> }
>
> Regards
> Alan
>
>
> On Tue, 2005-10-18 at 12:15 +0200, Arnaud Limbourg wrote:
>
>
| |
| Helgi Žormar 2005-10-19, 7:56 am |
| On Wed, 19 Oct 2005 11:07:26 +0200, Arnaud Limbourg wrote:
> Alan's solution should help.
>
> Helgi, can you test that and commit it if it works ?
Maybe, but probably not, I do not have much or any time at all on my hands :/
Helgi
|
|
|
|
|