PHP PEAR Questions and Answers - Re: [PEAR-QA] HTTP

Author

Re: [PEAR-QA] HTTP_Upload patches

Stefan Neufeind

2004-05-28, 9:32 pm

On 29 May 2004 at 2:42, Christian Wenz wrote:

> to my great surprise fellow PEAR user Antonio committed several patches
> to HTTP_Upload today. I certainly appreciate all help on this (or any
> other) package, however I was rather surprised because he is not listed
> on the package's website but obviously has write access to the CVS
> directory (which I don't, but that's another story :) ).
> As I wrote a couple of days ago, I have prepared a "monster patch" that
> includes some of the fixes Antonio has committed, however it also
> contains additonal patches.
> My question is what the general recommendation in this case is: shall I
> try to apply my patches to the current version in CVS (as soon as I have
> write access; would mean doing the same kind of work again, but is
> probably the preferable solution), or should I just commit "my version"
> of the package (which would mean overwriting Antonio's efforts)? I
> appreciate your opinions on that.

How large are those changes that Antonio did? If those were just a
few lines that you are sure you have done as good as him, then I
don't see a problem why you couldn't simply commit your patch.
Otherwise maybe doing a local cvs merge and trying it out might also
be a good solution.

Just make sure you don't exchange good (and maybe quite large and
maybe extensively tested) patches of Antonio with quickfixes of yours
or something like that. Everything else is fine imho.

Stefan

Helgi Þormar

2004-05-28, 11:32 pm

My biggest question is, did he have "permission" to commit ?
Since IMO it's rude to commit something before letting the author know,
or QA if the package doesn't have any active developer, or maybe even
email PEAR-Dev about it first?

Just my thoughts on this though.

Lukas Smith

2004-05-29, 4:32 am

Christian Wenz wrote:
> Dear QAers,
>
> to my great surprise fellow PEAR user Antonio committed several patches
> to HTTP_Upload today. I certainly appreciate all help on this (or any
> other) package, however I was rather surprised because he is not listed
> on the package's website but obviously has write access to the CVS
> directory (which I don't, but that's another story :) ).
> As I wrote a couple of days ago, I have prepared a "monster patch" that
> includes some of the fixes Antonio has committed, however it also
> contains additonal patches.
> My question is what the general recommendation in this case is: shall I
> try to apply my patches to the current version in CVS (as soon as I have
> write access; would mean doing the same kind of work again, but is
> probably the preferable solution), or should I just commit "my version"
> of the package (which would mean overwriting Antonio's efforts)? I
> appreciate your opinions on that.

feel free to revert.
but ideally first try to talk to him about the why's and how's etc :-)

regards,
Lukas Smith
smith@backendmedia.com
_______________________________
BackendMedia
www.backendmedia.com
berlin@backendmedia.com

Linn Zwoch Smith GbR
Pariser Str. 44
D-10707 Berlin

Tel +49 30 83 22 50 00
Fax +49 30 83 22 50 07

Christian Wenz

2004-05-29, 4:32 am

> My biggest question is, did he have "permission" to commit ?

AFAIK: no. But I got involved with this package just a couple of w

s
ago, so I don't know of any "grandfather" rules :) And Antonio has
committed bugfixes to HTTP_Upload before. There must be a reason why he
has the priviledges ;-)

> Since IMO it's rude to commit something before letting the author know,
> or QA if the package doesn't have any active developer, or maybe even
> email PEAR-Dev about it first?

Yep, I consider it very rude; but if it helps the package, I'd like to
try to find a way to work it out.

Regards
Christian

Pierre-Alain Joye

2004-05-29, 4:32 am

On Sat, 29 May 2004 02:18:17 +0000
helgi@trance.is (Helgi =DEormar) wrote:

> My biggest question is, did he have "permission" to commit ?
> Since IMO it's rude to commit something before letting the author
> know, or QA if the package doesn't have any active developer, or
> maybe even email PEAR-Dev about it first?
>=20
> Just my thoughts on this though.

You are right. As stated by David yesterday (html_form thread),
commit to a tree without permissions is a NO-NO. That's true for
every single package. Orphaned or foobar'ed packages has first to be
discussed on this list.

--Pierre

Christian Wenz

2004-05-29, 4:32 am

Lukas Smith wrote:

[...]

>
> feel free to revert.
> but ideally first try to talk to him about the why's and how's etc :-)
>

of course, I do want to use the option that he has CVS access :) I've
already mailed him (and persuaded him to subscribe to pear-qa) so we
will find a way to work it out. Thanks for all your opinions!

Christian

David Costa

2004-05-29, 1:33 pm

On May 29, 2004, at 9:32 AM, Pierre-Alain Joye wrote:

> On Sat, 29 May 2004 02:18:17 +0000
> helgi@trance.is (Helgi =DEormar) wrote:
>
>
> You are right. As stated by David yesterday (html_form thread),
> commit to a tree without permissions is a NO-NO. That's true for
> every single package. Orphaned or foobar'ed packages has first to be
> discussed on this list.

Right, if I am not mistaken Antonio was the one telling me on the list=20=

something like why do I think he cannot commit on my tree.... sigh

I hope that these are isolated incidents. If this happens again with=20
Antonio or anyone else It would probably make sense to call for votes=20
the removal of the karma
for the offender in the whole PEAR tree or better said the restriction=20=

of his karma to his own tree if any.

In fact Antonio is not the maintainer in any package, so how he got the=20=

karma for the whole PEAR tree remains a mystery to me.

To clarify, with this I do not imply that mutual help among PEAR=20
developers is no no. I am sure that every developer would welcome some=20=

further help but
an authorisation from the package lead before committing anything is=20
necessary.

Regards
David Costa

>
> --Pierre
>
> --
> PEAR QA Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>

Antonio Carlos Venancio Junior

2004-05-31, 10:33 am

Pierre,

long time no "see". hehe

Pierre-Alain Joye wrote:
> On Sat, 29 May 2004 02:18:17 +0000
> helgi@trance.is (Helgi Þormar) wrote:
>
>
>
>
> You are right. As stated by David yesterday (html_form thread),
> commit to a tree without permissions is a NO-NO. That's true for
> every single package. Orphaned or foobar'ed packages has first to be
> discussed on this list.

actually I've mailed the leads (cox and wenz) as I always did. We are
working on a merged version now. Cox seems to be dead and Wenz doesn't
have enough karma to do it.

P.S.: something is wrong with your domain:
# dig @TLD1.ULTRADNS.NET pearfr.org
;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 21214
--

Ate'

Antonio
"Can't buy what I want because its FREE!" - Pearl Jam

David Costa

2004-05-31, 10:33 am

On May 31, 2004, at 3:50 PM, Antonio Carlos Venancio Junior wrote:

snip
[color=darkred]
>
> actually I've mailed the leads (cox and wenz) as I always did. We are
> working on a merged version now. Cox seems to be dead and Wenz doesn't
> have enough karma to do it.
>

Well you can't email and commit. You email, wait a written approval and
commit.
Cox is not dead BTW :) and Wenz doesn't seem to have a karma problem.

In any case do not commit again in someone else tree without his
approval via email.
I don't even know how you have karma for the whole PEAR tree.

Cheers
David Costa

> P.S.: something is wrong with your domain:
> # dig @TLD1.ULTRADNS.NET pearfr.org
> ;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 21214
> --
>
> Ate'
>
> Antonio
> "Can't buy what I want because its FREE!" - Pearl Jam
>
> --
> PEAR QA Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>

Pierre-Alain Joye

2004-05-31, 10:33 am

On Mon, 31 May 2004 15:55:07 +0200
gurug

@php.net (David Costa) wrote:

> In any case do not commit again in someone else tree without his
> approval via email.
> I don't even know how you have karma for the whole PEAR tree.

Antonia has got the karma months (years? ;)) ago, that's not the
point :)

However, still asking before commit should always be the way.

--Pierre

Antonio Carlos Venancio Junior

2004-05-31, 11:33 am

Pierre,

Pierre-Alain Joye wrote:
> On Mon, 31 May 2004 15:55:07 +0200
> gurug

@php.net (David Costa) wrote:
>
>
>
>
> Antonia has got the karma months (years? ;)) ago, that's not the
> point :)

Years. And I agree with you - that's not the point.

> However, still asking before commit should always be the way.

I'm doing that way. And I've already asked Cox to put me as helper (or
whatever it's called) on his package.
--

Ate'

Antonio
"Can't buy what I want because its FREE!" - Pearl Jam

Tomas V.V.Cox

2004-05-31, 5:33 pm

David Costa wrote:
>
> Cox is not dead BTW :)

Hi guys, I'm somehow alive again :)

Tomas V.V.Cox

Helgi Þormar

2004-05-31, 5:33 pm

On Mon, 2004-05-31 at 20:24, Tomas V.V.Cox wrote:
> David Costa wrote:
>
> Hi guys, I'm somehow alive again :)
>
> Tomas V.V.Cox

o_O the living dead one! :/ :D

--
Regards

Helgi

Stefan Neufeind

2004-05-31, 6:32 pm

On 31 May 2004 at 22:24, Tomas V.V.Cox wrote:

> David Costa wrote:
>
> Hi guys, I'm somehow alive again :)
>
> Tomas V.V.Cox

Hey, nice to hear back from you. So you finally got your time
"sorted" in a way? It's a pleasure to have you back :-)

Stefan

Tomas V.V.Cox

2004-06-01, 6:34 am

Stephan Schmidt wrote:
> Hi,
>
>
> Does this mean you'll be actively developing your packages again?
>

My first plan is to actively work only on the PEAR package, for the rest
I'll do only QA and administrative tasks (helping or searching new leads).

Tomas V.V.Cox

Stephan Schmidt

2004-06-01, 7:36 am

Hi,

> My first plan is to actively work only on the PEAR package,
> for the rest
> I'll do only QA and administrative tasks (helping or
> searching new leads).

I took over XML_Parser and XML_DTD of your packages. I'd be very happy
to keep XML_Parser (as I got plans providing subclasses that support
entities, xinc, namespaces, etc), and I'm also able to maintain XML_DTD
if you like, although I think there's some restructering needed so it
matches the new regulations (Filename/Classname, etc.).

Stephan

David Costa

2004-06-01, 8:34 am

On Jun 1, 2004, at 12:02 PM, Tomas V.V.Cox wrote:

> Stephan Schmidt wrote:
>
> My first plan is to actively work only on the PEAR package, for the
> rest I'll do only QA and administrative tasks (helping or searching
> new leads).

Do you need anyone on Net_IRC ? :D

>
> Tomas V.V.Cox
>
> --
> PEAR QA Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>

Sponsored Links