| Hannes Magnusson 2007-02-25, 7:58 am |
| Hi Lajos
On 2/25/07, Lajos Cseppent=F5 <chappychyc8@gmail.com> wrote:
> Hello!
>
> I've modified a bit the phpdoc-hu Makefile script on my computer. I've ad=
ded
> reviewedcheck and I've created a "revchecks" option, which creates
> revcheck.html and reviewedcheck.html.
>
>
> Line: 125
> revcheck: revcheck.html
> reviewedcheck: reviewedcheck.html
> revchecks: revchecks.html
>
> [...] Line ~151:
>
> revcheck.html: FORCE
> PHPDOCDIR=3D$(srcdir) $(PHP) -c $(scriptdir) -f $(scriptdir)/revcheck.ph=
p
> $(LANGDIR) > revcheck.html
>
> reviewedcheck.html: FORCE
> PHPDOCDIR=3D$(srcdir) $(PHP) -c $(scriptdir) -f
> $(scriptdir)/reviewedcheck.php $(LANGDIR) > reviewedcheck.html
>
> revchecks.html: FORCE
> PHPDOCDIR=3D$(srcdir) $(PHP) -c $(scriptdir) -f $(scriptdir)/revcheck.ph=
p
> $(LANGDIR) > revcheck.html
> PHPDOCDIR=3D$(srcdir) $(PHP) -c $(scriptdir) -f
> $(scriptdir)/reviewedcheck.php $(LANGDIR) > reviewedcheck.html
(these are tabs, right? not a single space?)
>
>
> What do you think? Is it a good code (it semms it works). Should I commit
> this change in Makefile.in and upload to CVS?
Sounds like a good idea to me.
Only one thing: I don't see the point of "PHPDOCDIR=3D", it is
meaningless (never used) and is just confusing, IMO.
Also you may want to add reviewedcheck.html into the cleaning section.
In the future, please post unified diff (cvs diff -u Makefile.in >
my.patch.txt) as it is more readable as we see the exact changes right
away...
-Hannes
>
> Best Regards,
> Lajos
>
|