Home > Archive > PHP Documentation > October 2007 > Re: [PHP-DOC] Patch for mysql_escape_string
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
Re: [PHP-DOC] Patch for mysql_escape_string
|
|
| Paul Reinheimer 2007-10-02, 7:02 pm |
| Thanks for the feedback,
Comments/questions
- Removed the whitespace, thanks
- According to the ascii chart's i've read the official name for that
character is Substitue, ?
- Moved the note, considered a warning, but chickened out
patch attachd
paul
--
Paul Reinheimer
Zend Certified Engineer
| |
| Philip Olson 2007-10-02, 7:02 pm |
|
On Oct 2, 2007, at 12:17 PM, Hannes Magnusson wrote:
> On 10/2/07, Paul Reinheimer <preinheimer@gmail.com> wrote:
>
> My books say that too.
>
>
> I recommend manning up :)
> If the notes section is the correct place for it however..
>
> I like the idea, but it could be a problem for people needing to know
> "does that mean it emits an error message now? When is "now"?"
> Then again, they are using depreciation function....
I prefer keeping changelog information whenever possible so think we
should keep it there. However, this brings us to thinking about how
we treat deprecated functions and features. Although deprecated in
PHP typically doesn't mean much, it's still very important
information and should be impossible to miss while reading the given
manual entry. And since the notes section lives near the bottom of
the page, I wonder if it's indeed the appropriate place. My initial
feeling tells me the deprecated information should instead be near
the top, in the description, and as a warning. This is a good time to
think about this topic and after coming up with a solution we apply
it to all deprecated functions throughout the PHP manual. Or maybe
have its own role under the description? It's own role would make it
easier to generate a list of all deprecated functions... or... hmm...
Regards,
Philip
|
|
|
|
|