| takagi@php.net 2006-03-22, 6:59 pm |
| ID: 36822
Updated by: takagi@php.net
Reported By: jimmy at powerzone dot dk
-Status: Open
+Status: Closed
Bug Type: Documentation problem
Operating System: Linux
PHP Version: Irrelevant
New Comment:
This bug has been fixed in the documentation's XML sources. Since the
online and downloadable versions of the documentation need some time
to get updated, we would like to ask you to be a bit patient.
Thank you for the report, and for helping us make our documentation
better.
I verified it in DOMXML (/repository/pecl/domxml/php_domxml.c).
****
/* {{{ proto object domxml_node_replace_child(object newnode, object
oldnode)
Replaces node in list of children */
PHP_FUNCTION(domxml_node_replace_child)
{
...
if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "oo", &newnode,
&oldnode) == FAILURE) {
return;
}
...
}
****
Previous Comments:
------------------------------------------------------------------------
[2006-03-22 18:38:41] colder@php.net
The source quote was about DOM and not DOMXML, sorry.
The documentation problem might not be verified.
------------------------------------------------------------------------
[2006-03-22 18:29:00] colder@php.net
It seems to be verified, according to the source:
****
PHP_FUNCTION(dom_node_replace_child)
{
...
if (zend_parse_method_parameters(ZEND_NUM_A
RGS() TSRMLS_CC,
getThis(), "OOO", &id, dom_node_class_entry, &newnode,
dom_node_class_entry, &oldnode, dom_node_class_entry) == FAILURE) {
return;
}
****
Here is the patch :
http://patches.colder.ch/domnode-replace-hild.patch
Thanks in advance.
------------------------------------------------------------------------
[2006-03-22 15:59:21] jimmy at powerzone dot dk
Description:
------------
Please browse to the following link :
http://dk.php.net/manual/fi/functio...place-child.php
According to the documentation, the function should be called like this
:
DomNode->replace_child(oldNode, newNode)
This is WRONG!. It should be called like this :
DomNode->replace_child(newNode, oldNode)
I spend hours before I looked in the User Contribution Notes and found
the answer. Please correct this bug ASAP as it will save other
programmers a lot of time.
Reproduce code:
---------------
NA
Expected result:
----------------
NA
Actual result:
--------------
NA
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=36822&edit=1
|