Critical Bug in Net::LDAP v0.35

I have discovered a critical bug in Net::LDAP 0.35 and submitted the
following ticket:
http://rt.cpan.org/Ticket/Display.html?id=34878

In 0.35, the Net::Ldap::Util::ldap_error_name subroutine is broken which
means that all functions such as Net::LDAP->code() that return a message
as a constant are broken.

Instead of returning the correct message, Password Policy (PP) constants
are being returned instead.

The most crucial example is that a successful bind or search is
returning LDAP_PP_PASSWORD_EXPIRED (0) instead of LDAP_SUCCESS (0). You
can code around this failure by using resultCode() instead to get the
integer form of the result code, however all current perl modules that
determine results by using the constant names will function unexpectedly.

Please advise me *quickly* if you think for any reason that I have the
wrong end of the stick here, but having passed it by a few colleagues
I'm pretty damn sure this is a bug and a critical one.
--
Kind Regards,

 ________________________________________
__________

Mike Peachey, IT
Tel: +44 114 281 2655
Fax: +44 114 281 2951
Jennic Ltd, Furnival Street, Sheffield, S1 4QT, UK
Comp Reg No: 3191371 - Registered In England
http://www.jennic.com
 ________________________________________
__________

Hi Mike,

On Friday, 11. April 2008, Mike Peachey wrote:
> I have discovered a critical bug in Net::LDAP 0.35 and submitted the
> following ticket:
> http://rt.cpan.org/Ticket/Display.html?id=34878
>
> In 0.35, the Net::Ldap::Util::ldap_error_name subroutine is broken which
> means that all functions such as Net::LDAP->code() that return a message
> as a constant are broken.
>
> Instead of returning the correct message, Password Policy (PP) constants
> are being returned instead.
>
> The most crucial example is that a successful bind or search is
> returning LDAP_PP_PASSWORD_EXPIRED (0) instead of LDAP_SUCCESS (0). You
> can code around this failure by using resultCode() instead to get the
> integer form of the result code, however all current perl modules that
> determine results by using the constant names will function unexpectedly.
>
> Please advise me *quickly* if you think for any reason that I have the
> wrong end of the stick here, but having passed it by a few colleagues
> I'm pretty damn sure this is a bug and a critical one.

You are right, this is a bug.

I committed a patch to perl-ldap-SVN to fix it.
For you convenience I also append it to this posting.

Please test and report back.

CU
PEter

--
Peter Marschall
peter@adpm.de

Peter Marschall wrote:
> Hi Mike,
>
> On Friday, 11. April 2008, Mike Peachey wrote: 
>
> You are right, this is a bug.
>
> I committed a patch to perl-ldap-SVN to fix it.
> For you convenience I also append it to this posting.
>
> Please test and report back.

I have tested the patch with a test perl script and it resolves the
problem (obviously, given the way the array is built).

While the patch works and I heartily thank you for it, my primary
concern is getting the fix out to the Net::LDAP distribution on CPAN.

For my own purposes I have remained on 0.34 but I maintain an LDAP and
DBI external authentication extension for RT from BestPractical and for
those who are just taking up the extension and coming with up to date
perl installs the extension is broken.

I'm not familiar with the development hierarchy and roll-out process for
Net::LDAP, do you think it may be put to a release soon, or should I
code a new version of my extension using integer result codes and
release it?

Thanks for your help.
--
Kind Regards,

 ________________________________________
__________

Mike Peachey, IT
Tel: +44 114 281 2655
Fax: +44 114 281 2951
Jennic Ltd, Furnival Street, Sheffield, S1 4QT, UK
Comp Reg No: 3191371 - Registered In England
http://www.jennic.com
 ________________________________________
__________

On 16 Apr 2008, at 21:39, Mike Peachey wrote:

> Peter Marschall wrote: 
>
> I have tested the patch with a test perl script and it resolves the
> problem (obviously, given the way the array is built).
>
> While the patch works and I heartily thank you for it, my primary
> concern is getting the fix out to the Net::LDAP distribution on CPAN.
>
> For my own purposes I have remained on 0.34 but I maintain an LDAP
> and DBI external authentication extension for RT from BestPractical
> and for those who are just taking up the extension and coming with
> up to date perl installs the extension is broken.
>
> I'm not familiar with the development hierarchy and roll-out process
> for Net::LDAP, do you think it may be put to a release soon, or
> should I code a new version of my extension using integer result
> codes and release it?

I think we should release a new version ASAP. Graham does all the
release engineering...

Cheers,

Chris

On Apr 17, 2008, at 12:51 PM, Chris Ridd wrote:
> I think we should release a new version ASAP. Graham does all the
> release engineering...

I will do a release this wend (or before if I get time) and also a
new release of Authen::SASL

Graham.

Graham Barr wrote:
> On Apr 17, 2008, at 12:51 PM, Chris Ridd wrote: 
>
> I will do a release this wend (or before if I get time) and also a
> new release of Authen::SASL
>
> Graham.
>

Much appreciated. Thanks for the quick responses everyone. I'll get back
to coding my latest feature request :)
--
Kind Regards,

 ________________________________________
__________

Mike Peachey, IT
Tel: +44 114 281 2655
Fax: +44 114 281 2951
Jennic Ltd, Furnival Street, Sheffield, S1 4QT, UK
Comp Reg No: 3191371 - Registered In England
http://www.jennic.com
 ________________________________________
__________