Code Comments
Programming Forum and web based access to our favorite programming groups.
Sketch Editor 1.0Hello On 15/May/08 I posted a first version of my Sketch Editor on the daisy issue tracker. Meanwhile, I added some functionality, and fixed some errors. I put the current version again on the issue tracker. Are you interested in integrating this editor to the Daisy project? Please let me know in the next 1-2 ws, as my internship ends by the end of June. Regards, Michael ________________________________________ _______ daisy community mailing list Professional Daisy support: http://outerthought.org/en/services...rt.html mail to: daisy-81qHHgoATdGcMQoVcdA18UB+6BGkLq7r@public.gmane.org list information: http://lists.cocoondev.org/mailman/listinfo/daisy
Post Follow-up to this message
Re: Sketch Editor 1.0Yes, we are still interested in integrating the editor (i.e. evaluate whether its implementation is of sufficient quality). I was planning to do this somewhere before the next Daisy release (september), but it is too soon to say when I will have time to do so. In the mean time, I had a quick look. Perhaps I overlooked, but I did not find the source-code for your work. Also, was there a reason to merge your code and jhotdraw code in one jar file? (It should be possible to run applets with different jarfiles, so there is no need to do that). =EF=BB=BF=EF=BB=BFIf you could structure the zip-file so that it contains= a working build and build instructions, it would be very helpful. =EF=BB=BF I am currently working on another applet, which is built using maven. http://svn.cocoondev.org/viewsvn/br...T/daisy/applic= ations/daisywiki/parteditor-applet/ * ideally, your build should prepare a directory structure which is identical to the contents of your zipfile), the wiki frontend script will copy all resources to the appropriate locations * The jhotdraw dependency does not need to be included in your code (maven, the build tool used for daisy takes care of downloading dependencies, for your convenience I have already put the jhotdraw jar file up on the maven repository at svn.cocoondev.org). You you may want to have a look at how the daisywiki frontend build scripts copies dependencies to its target directory. Apart from that, I also noticed that your classes are compiled with Java 6. Because the applets should run on as many clients as possible, you should get it down at least to Java 1.5 (Apparently there still is no Java 6 for Mac(?)) This should not be a problem, it is usually a matter of compiler settings. Regards, Karel On Tue, 2008-06-10 at 14:34 +0200, Michael H=C3=A4nni wrote: > Hello >=20 > On 15/May/08 I posted a first version of my Sketch Editor on the daisy=20 > issue tracker. Meanwhile, I added some functionality, and fixed some=20 > errors. I put the current version again on the issue tracker. Are you=20 > interested in integrating this editor to the Daisy project? > Please let me know in the next 1-2 w
Post Follow-up to this message Re: Sketch Editor 1.0Hi Karel, great to hear this! I will do the changes you mentioned, and provide a new zip file within a=20 w
Post Follow-up to this message Re: Sketch Editor 1.0I could not find which jar file to put in our repository, I completely disagree with the last paragraph of=20 http://www.randelshofer.ch/oop/jhot.../getting_start= ed.html Can you document your code in a way which makes it clear how everything ties together (which jar file comes from where?) I will not agree to copying the code from other projects into the daisy codebase as described on that page, it makes no sense to me. I hope we can come to a more sensible solution (e.g. one where jhotdraw is built from source as part of building the applet, just like cocoon is built from source when the wiki is built. Sorry for the inconvenience, Karel On Tue, 2008-06-10 at 16:02 +0200, Michael H=C3=A4nni wrote: > Hi Karel, >=20 > great to hear this! > I will do the changes you mentioned, and provide a new zip file within = a=20 > w
Post Follow-up to this message Re: Sketch Editor 1.0Hi Karel Contrary to the mentioned suggestion of JhotDraw, my applet uses a=20 jhotdraw-jar file as a library. It was not my intention to put JHotDraw=20 source code into the daisy codebase. All the jar files of my applet go into the Daisy-Wiki folder: - two go into daisyhome\daisywiki\webapp\WEB-INF\lib - one goes into daisyhome\daisywiki\webapp\daisy\resourc es\sketchApplet I will change my zip-file, so that it contains a working build and build=20 instructions. Regards, Michael Karel Vervaeke schrieb: > I could not find which jar file to put in our repository, I completely > disagree with the last paragraph of=20 > > http://www.randelshofer.ch/oop/jhot...on/getting_sta= rted.html > > Can you document your code in a way which makes it clear how everything > ties together (which jar file comes from where?) I will not agree to > copying the code from other projects into the daisy codebase as > described on that page, it makes no sense to me. I hope we can come to > a more sensible solution (e.g. one where jhotdraw is built from source > as part of building the applet, just like cocoon is built from source > when the wiki is built. > > Sorry for the inconvenience, > Karel > > > > On Tue, 2008-06-10 at 16:02 +0200, Michael H=C3=A4nni wrote: > =20 a=20 to s d jar so ains a working plications/daisywiki/parteditor-applet/ r ant ava u ter sy=20 =20 u=20 he=20 y/support.html /support.html support.html > ________________________________________ _______ > daisy community mailing list > Professional Daisy support: http://outerthought.org/en/services/daisy/s= upport.html > mail to: daisy-81qHHgoATdGcMQoVcdA18UB+6BGkLq7r@public.gmane.org > list information: http://lists.cocoondev.org/mailman/listinfo/daisy > =20 ________________________________________ _______ daisy community mailing list Professional Daisy support: http://outerthought.org/en/services/daisy/sup= port.html mail to: daisy-81qHHgoATdGcMQoVcdA18UB+6BGkLq7r@public.gmane.org list information: http://lists.cocoondev.org/mailman/listinfo/daisy
Post Follow-up to this message Re: Sketch Editor 1.0Some more notes: * The unpacked daisywiki structure contains resources/sketchApplet but the form template references resources/SketchApplet/ergon-... This will not work in unix environments because the paths are case-sensitive. * In the readme file you wrote SketchDokument - you probably want to change this to SketchDocument, as the document-styling files use the English notation. (I know it's nitpicking, but I had to go back and change my document name, so you might want to fix it). * (BTW, found your source code alongside the class files in the end, as noted before, you should try separate them and only distribute the source + a build system.) =EF=BB=BFOther than that, you probably spent a lot of time, things look g= ood and we're entusiastic - don't be put down by my feedback and do not hesitate to ask if you have questions. Don't worry if you don't get everything entirely finished, the least we can do is take our share of work to integrate your work into the Daisy codebase. Regards, Karel On Tue, 2008-06-10 at 16:02 +0200, Michael H=C3=A4nni wrote: > Hi Karel, >=20 > great to hear this! > I will do the changes you mentioned, and provide a new zip file within = a=20 > w
Post Follow-up to this message Re: Sketch Editor 1.0I understand, but it is unclear to me which JHotDraw jar file you are using (There are a whole bunch of jar files in the JHotDraw distribution). As far as I understand you are using the jar file from the 'Draw' sample application (one of the files below - it is unclear to me what the relation between them is and whether or not they depend on each other) ./Draw/jhotdraw_draw.jar ./Draw/JHotDraw Draw.jar ./Draw/jhotdraw_draw_signed.jar ./Draw/libquaqua.jnilib_signed.jar ./Draw/JHotDraw Draw_signed.jar The applet jarfile also contains some org.jhotdraw.** classfiles * this is not necessarily bad, but it would be nicer to keep them in a separate jarfile (i.e. reuse a pre-built jarfiles if it is available or build from source when building the applet) Regards, Karel On Tue, 2008-06-10 at 16:58 +0200, Michael H=C3=A4nni wrote: > Hi Karel >=20 > Contrary to the mentioned suggestion of JhotDraw, my applet uses a=20 > jhotdraw-jar file as a library. It was not my intention to put JHotDraw= =20 > source code into the daisy codebase. > All the jar files of my applet go into the Daisy-Wiki folder: > - two go into daisyhome\daisywiki\webapp\WEB-INF\lib > - one goes into daisyhome\daisywiki\webapp\daisy\resourc es\sketchApplet >=20 > I will change my zip-file, so that it contains a working build and buil= d=20 > instructions. >=20 > Regards, > Michael >=20 >=20 > Karel Vervaeke schrieb: y tarted.html ng to e in a=20 te ng to is did e jar , so ntains a working n. applications/daisywiki/parteditor-applet/ t jar want Java you no atter aisy=20 me=20 you=20 the=20 isy/support.html y sy/support.html y/support.html /support.html >=20 > ________________________________________ _______ > daisy community mailing list > Professional Daisy support: http://outerthought.org/en/services/daisy/s= upport.html > mail to: daisy-81qHHgoATdGcMQoVcdA18UB+6BGkLq7r@public.gmane.org > list information: http://lists.cocoondev.org/mailman/listinfo/daisy ________________________________________ _______ daisy community mailing list Professional Daisy support: http://outerthought.org/en/services/daisy/sup= port.html mail to: daisy-81qHHgoATdGcMQoVcdA18UB+6BGkLq7r@public.gmane.org list information: http://lists.cocoondev.org/mailman/listinfo/daisy
Post Follow-up to this message Re: Sketch Editor 1.0Thanks for the hints. The jar files in the JHotDraw distribution do not depend on each other. For the current version, I took ./Draw/jhotdraw_draw.jar, but I modified=20 some classes. For the next version I try to clearly sepparate the=20 jhotdraw-jar from my jars. Regards, Michael Karel Vervaeke schrieb: > I understand, but it is unclear to me which JHotDraw jar file you are > using (There are a whole bunch of jar files in the JHotDraw > distribution). As far as I understand you are using the jar file from > the 'Draw' sample application (one of the files below - it is unclear t= o > me what the relation between them is and whether or not they depend on > each other) > > ./Draw/jhotdraw_draw.jar > ./Draw/JHotDraw Draw.jar > ./Draw/jhotdraw_draw_signed.jar > ./Draw/libquaqua.jnilib_signed.jar > ./Draw/JHotDraw Draw_signed.jar > > The applet jarfile also contains some org.jhotdraw.** classfiles > * this is not necessarily bad, but it would be nicer to keep them in a > separate jarfile (i.e. reuse a pre-built jarfiles if it is available or > build from source when building the applet) > > Regards, > Karel > > On Tue, 2008-06-10 at 16:58 +0200, Michael H=C3=A4nni wrote: > =20 w=20 t ld=20 y tarted.html ng to e in a=20 te ng to is did e jar , so ntains a working n. applications/daisywiki/parteditor-applet/ t jar want Java you no atter aisy=20 me=20 you=20 the=20 isy/support.html y sy/support.html y/support.html /support.html support.html > ________________________________________ _______ > daisy community mailing list > Professional Daisy support: http://outerthought.org/en/services/daisy/s= upport.html > mail to: daisy-81qHHgoATdGcMQoVcdA18UB+6BGkLq7r@public.gmane.org > list information: http://lists.cocoondev.org/mailman/listinfo/daisy > =20 ________________________________________ _______ daisy community mailing list Professional Daisy support: http://outerthought.org/en/services/daisy/sup= port.html mail to: daisy-81qHHgoATdGcMQoVcdA18UB+6BGkLq7r@public.gmane.org list information: http://lists.cocoondev.org/mailman/listinfo/daisy
Post Follow-up to this message
Sponsored Links
Show a Printable Version
Email This Page to Someone!
Receive updates to this thread
Powered by vBulletin
Copyright 2000-2006 Jelsoft Enterprises Limited.
